Build with arm versions #528
Conversation
| @@ -23,8 +23,10 @@ bootstrap-dist: | |||
| build-all: | |||
| gox -verbose \ | |||
| -ldflags "-X main.version=${VERSION}" \ | |||
| -ldflags "-X main.version=${VERSION}" \ | |||
|
Hi @dnephin. Thanks for the warning. |
| @@ -24,7 +24,8 @@ build-all: | |||
| gox -verbose \ | |||
| -ldflags "-X main.version=${VERSION}" \ | |||
| -os="linux darwin windows " \ | |||
| -arch="amd64 386" \ | |||
| -arch="amd64 386 armv5 armv6 armv7 arm64" \ | |||
There was a problem hiding this comment.
I just tried it out and I don't think armv{5,6,7} are valid. It just ignores the arch's it doesn't know about.
I believe only arm and arm64 are valid.
There was a problem hiding this comment.
As explained in the first conversation of this PR you must use a gox fork to work.
There was a problem hiding this comment.
fwiw, I built with just arm and it's working fine on armv7.
There was a problem hiding this comment.
Nice, but as stated here
In cross compilation situations, it is recommended that you always set an appropriate GOARM value along with GOARCH.
|
I'm keeping an eye on it and we'll have this in some manner before the next release. I want to see if Mitchell will merge upstream. |
|
It seems Mitchell has not merged this upstream and has not responded to emails either. I will likely look at using the fork for now. |
|
@mattfarina |
This includes Merge pull request #528 from franciscocpg/master to build arm
|
@franciscocpg thanks for the contribution. For gox I'm pulling from your repo for the time being. If in the next couple release cycles upstream gox doesn't merge the work we'll deal with it. |
|
@franciscocpg I'm going to start a Masterminds/gox fork... as you have suggested. I'm going to add you to the repo. This was a collective we can maintain it. Note, I've emailed Mitchell about gox and if anything comes in I'll let you know. |
|
Nice @mattfarina! 👍 |
For this to work with
goxthis gox PR needs to be merged.While it does not happen (And I don't know if someday it will), it's possible to use the fork https://github.com/franciscocpg/gox.
After merging this PR, it is necessary to run
make distand publish the new arm dists to the latest glide release.Also this glide.sh PR needs to be merged so one can install glide on a arm device with
curl https://glide.sh/get | sh.